覆盖 Phase 2e-2 代码审查报告(docs/reviews/2026-04-23-phase2e-2-code-review.md) P2/Nit 收尾批次,均在本仓库完成闭环;剩余 5 项登记推迟至 Phase 2f/3。 ===== P2 七项 ===== - P2-1 cleanupUserResources 补 transport 清理 · media-server 新增 DELETE /internal/v1/transports/:id + transport.service.closeTransport · Go MediaOrchestrator 接口新增 CloseTransport;HTTP 实现按 doCloseRequest 走 4xx 幂等 + 指数退避 · meeting_signal_service.cleanupUserResources 新增 "transport:<id>" 分支 - P2-2 preview.vue 快速切设备竞态 · previewSeq 序号 + nextTick 后 stale 判断,丢弃过期结果 · onVideoChange/onAudioChange 走 scheduleRestartPreview 200ms 防抖 · onBeforeUnmount 清理 changeDebounceTimer - P2-3 room.vue onLoad redirectTo 后补 return · 引入 redirectingToJoin 守卫,跳转页不再执行 onMounted 初始化 - P2-6 generateUniqueRoomCode 重试上限监控 · 重试后成功:Warn 日志(码空间健康度告警) · 重试耗尽:Error 日志 + ErrRoomCodeConflict · 修正 logs.Error 调用签名(去掉多余的 nil) - P2-7 SendChatMessage 服务端长度 + 频率限制 · 新增 ErrChatContentEmpty / ErrChatContentTooLong / ErrChatRateLimited · utf8.RuneCountInString 校验 500 字符上限 · Redis INCR + EXPIRE 滑动窗口(30 条/60s,首次写入 EXPIRE 兜底) · controller.handleError 映射为 HTTP 400 - P2-8 MEETING_ENDED_REASON_LABEL 覆盖复核 · 新增前端专属常量 MEETING_ENDED_REASON_KICKED + 文案 · store/meeting.js _onMemberKicked 使用常量 · 同步修复后端 OnWSDisconnect 硬编码 "ws_disconnect" → constants.MeetingLeftReasonDisconnect - P2 已修 P2-1/2/3/6/7/8;P2-4(WS token 迁出 URL query)与 P2-5(Chat 服务拆分)登记推迟 ===== Nit 七项 ===== - Nit: kind:id 解析改用 strings.SplitN · cleanupUserResources / pushExistingRoomState 两处同步 - Nit: resourceTTL 中央化 · 新增 constants.MeetingResourceTrackTTLSeconds(3600) · meeting_signal_service.go resourceTTL 由 const 改 var 并引用常量 - Nit: ws/handler.go CheckOrigin 白名单 · NewHandler 新增 serverCfg 依赖;checkOrigin 支持同源放行 / dev 模式放行 / release 模式白名单严格匹配 · config.ServerConfig 新增 WSAllowedOrigins(逗号分隔)+ AllowedOrigins() / IsRelease() 辅助方法 · provider.go 新增 provideServerConfig,wire_gen.go 同步 - Nit: http_media_orchestrator.go 超时 + CreateRouter 重试 · 默认 TimeoutMS 5000→10000ms 兼容 Worker 冷启动 · 新增 CreateRouterRetry(默认 1 次,300ms 退避),仅对非 404 错误重试 · config.dev.yaml / config.docker.yaml 同步写入显式配置 - Nit: deploy-public.sh REDIS_PASSWORD × redis.conf 联动校验 · 检测 REDIS_PASSWORD 与 redis.conf 的 requirepass 配对一致性 · redis.conf 增加公网部署 requirepass 使用说明 - Nit: media-server internal-auth isPrivatePath 按 path 匹配 · 剔除 query/hash 后再与白名单 startsWith,避免 "?" 语义混淆 - Nit: mediasoup-client.js in-flight 锁走读确认 · finally 分支已覆盖 resolve/reject 两路,追加注释强化语义 - Nit 走读复核:_onMemberLeft 整槽关闭 vs _onProducerNew(closed=true) 精确匹配 producerId · 粒度正确,无需改动(登记结论) ===== 构建验证 ===== - go vet ./... / go build ./... 通过 - frontend npm run build:h5 通过(仅 uni-app legacy warning,无 error) - media-server npx tsc --noEmit 通过 ===== 审查追踪小节 ===== docs/reviews/2026-04-23-phase2e-2-code-review.md 追加 "Task 16 修复追踪(2026-04-24 更新)": - 已修复一览(本批次 14 处 + 历次 commitcdaa39d/ea2bf96/f5ae095/ 5ed14c2) - 推迟登记表(P2-4 / P2-5 / 端口收敛 / appData 校验 / RFC3339 时间格式,共 5 项) Made-with: Cursor
117 lines
6.7 KiB
Go
117 lines
6.7 KiB
Go
// Code generated by Wire. DO NOT EDIT.
|
||
|
||
//go:generate go run -mod=mod github.com/google/wire/cmd/wire
|
||
//go:build !wireinject
|
||
// +build !wireinject
|
||
|
||
package provider
|
||
|
||
import (
|
||
controller2 "github.com/echochat/backend/app/admin/controller"
|
||
dao2 "github.com/echochat/backend/app/admin/dao"
|
||
service2 "github.com/echochat/backend/app/admin/service"
|
||
"github.com/echochat/backend/app/auth/controller"
|
||
"github.com/echochat/backend/app/auth/dao"
|
||
"github.com/echochat/backend/app/auth/service"
|
||
controller3 "github.com/echochat/backend/app/contact/controller"
|
||
dao3 "github.com/echochat/backend/app/contact/dao"
|
||
service4 "github.com/echochat/backend/app/contact/service"
|
||
controller4 "github.com/echochat/backend/app/file/controller"
|
||
service5 "github.com/echochat/backend/app/file/service"
|
||
controller5 "github.com/echochat/backend/app/group/controller"
|
||
dao4 "github.com/echochat/backend/app/group/dao"
|
||
service6 "github.com/echochat/backend/app/group/service"
|
||
"github.com/echochat/backend/app/im"
|
||
controller7 "github.com/echochat/backend/app/meeting/controller"
|
||
dao6 "github.com/echochat/backend/app/meeting/dao"
|
||
service7 "github.com/echochat/backend/app/meeting/service"
|
||
task2 "github.com/echochat/backend/app/meeting/task"
|
||
controller6 "github.com/echochat/backend/app/notify/controller"
|
||
dao5 "github.com/echochat/backend/app/notify/dao"
|
||
service3 "github.com/echochat/backend/app/notify/service"
|
||
"github.com/echochat/backend/app/notify/task"
|
||
"github.com/echochat/backend/app/ws"
|
||
"github.com/echochat/backend/config"
|
||
"github.com/echochat/backend/pkg/db"
|
||
"github.com/echochat/backend/pkg/storage"
|
||
)
|
||
|
||
// Injectors from wire.go:
|
||
|
||
// InitializeApp 初始化整个应用(Wire 自动生成实现)
|
||
func InitializeApp(cfg *config.Config) (*App, error) {
|
||
databaseConfig := provideDBConfig(cfg)
|
||
gormDB, err := db.NewPostgres(databaseConfig)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
redisConfig := provideRedisConfig(cfg)
|
||
client, err := db.NewRedis(redisConfig)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
minioConfig := provideMinioConfig(cfg)
|
||
minioClient, err := storage.NewMinioClient(minioConfig)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
userDAO := dao.NewUserDAO(gormDB)
|
||
roleDAO := dao.NewRoleDAO(gormDB)
|
||
jwtConfig := provideJWTConfig(cfg)
|
||
tokenStore := service.NewTokenStore(client, jwtConfig)
|
||
authService := service.NewAuthService(userDAO, roleDAO, jwtConfig, tokenStore)
|
||
authController := controller.NewAuthController(authService)
|
||
adminAuthController := controller.NewAdminAuthController(authService)
|
||
userManageDAO := dao2.NewUserManageDAO(gormDB)
|
||
userManageService := service2.NewUserManageService(userManageDAO, userDAO, roleDAO)
|
||
userManageController := controller2.NewUserManageController(userManageService)
|
||
hub := ws.ProvideHub()
|
||
pubSub := ws.ProvidePubSub(client, hub)
|
||
friendshipDAO := dao3.NewFriendshipDAO(gormDB)
|
||
onlineService := ws.ProvideOnlineService(client, hub, pubSub, friendshipDAO)
|
||
onlineManageService := service2.NewOnlineManageService(onlineService, gormDB)
|
||
onlineController := controller2.NewOnlineController(onlineManageService)
|
||
contactManageService := service2.NewContactManageService(gormDB)
|
||
contactManageController := controller2.NewContactManageController(contactManageService)
|
||
groupDAO := dao4.NewGroupDAO(gormDB)
|
||
groupManageService := service2.NewGroupManageService(gormDB, groupDAO)
|
||
groupManageController := controller2.NewGroupManageController(groupManageService)
|
||
messageManageDAO := dao2.NewMessageManageDAO(gormDB)
|
||
conversationDAO := im.ProvideConversationDAO(gormDB)
|
||
messageManageService := service2.NewMessageManageService(messageManageDAO, userDAO, conversationDAO, pubSub)
|
||
messageManageController := controller2.NewMessageManageController(messageManageService)
|
||
serverConfig := provideServerConfig(cfg)
|
||
handler := ws.ProvideWSHandler(hub, pubSub, jwtConfig, serverConfig, onlineService, authService)
|
||
friendGroupDAO := dao3.NewFriendGroupDAO(gormDB)
|
||
notificationDAO := dao5.NewNotificationDAO(gormDB)
|
||
notifyService := service3.NewNotifyService(notificationDAO, pubSub, friendshipDAO)
|
||
contactService := service4.NewContactService(friendshipDAO, friendGroupDAO, onlineService, notifyService)
|
||
contactController := controller3.NewContactController(contactService)
|
||
messageDAO := im.ProvideMessageDAO(gormDB)
|
||
messageReadDAO := dao4.NewMessageReadDAO(gormDB)
|
||
imService := im.ProvideIMService(conversationDAO, messageDAO, pubSub, client, friendshipDAO, friendshipDAO, groupDAO, messageReadDAO)
|
||
imController := im.ProvideIMController(imService)
|
||
eventHandler := im.ProvideIMEventHandler(imService, hub)
|
||
offlinePusher := im.ProvideOfflinePusher(imService, conversationDAO, pubSub)
|
||
fileService := service5.NewFileService(minioClient, minioConfig)
|
||
fileController := controller4.NewFileController(fileService)
|
||
joinRequestDAO := dao4.NewJoinRequestDAO(gormDB)
|
||
groupService := service6.NewGroupService(groupDAO, joinRequestDAO, friendshipDAO, pubSub, messageDAO, notifyService)
|
||
groupController := controller5.NewGroupController(groupService)
|
||
notificationController := controller6.NewNotificationController(notifyService)
|
||
cleanupTask := task.NewCleanupTask(notificationDAO)
|
||
meetingRoomDAO := dao6.NewMeetingRoomDAO(gormDB)
|
||
meetingParticipantDAO := dao6.NewMeetingParticipantDAO(gormDB)
|
||
meetingChatDAO := dao6.NewMeetingChatDAO(gormDB)
|
||
meetingBroadcaster := service7.NewMeetingBroadcaster(meetingParticipantDAO, pubSub)
|
||
httpMediaOrchestrator := service7.NewHTTPMediaOrchestrator(cfg)
|
||
meetingLifecycleService := service7.NewMeetingLifecycleService(meetingRoomDAO, meetingParticipantDAO, client, meetingBroadcaster, httpMediaOrchestrator, cfg)
|
||
meetingService := service7.NewMeetingService(meetingRoomDAO, meetingParticipantDAO, meetingChatDAO, gormDB, client, meetingBroadcaster, notifyService, friendshipDAO, onlineService, httpMediaOrchestrator, meetingLifecycleService)
|
||
meetingSignalService := service7.NewMeetingSignalService(meetingRoomDAO, meetingParticipantDAO, client, meetingBroadcaster, httpMediaOrchestrator, meetingLifecycleService)
|
||
meetingController := controller7.NewMeetingController(meetingService)
|
||
meetingWSHandler := controller7.NewMeetingWSHandler(meetingSignalService, hub)
|
||
meetingCleanupTask := task2.NewMeetingCleanupTask(meetingLifecycleService, meetingRoomDAO, meetingChatDAO)
|
||
app := NewApp(cfg, gormDB, client, minioClient, authService, authController, adminAuthController, userManageController, onlineController, contactManageController, groupManageController, messageManageController, handler, hub, pubSub, onlineService, contactController, imController, eventHandler, offlinePusher, fileController, groupController, notifyService, notificationController, cleanupTask, meetingService, meetingSignalService, meetingLifecycleService, meetingController, meetingWSHandler, meetingCleanupTask)
|
||
return app, nil
|
||
}
|