feat(phase2e-2): media-server Task 0/1/2 落地 + 代码审查修复
本次提交一次性落盘 Phase 2e-2 的 Task 0（PoC Spike）、Task 1（骨架 + Fastify 5 升级） 和 Task 2（9 个内部 REST API + code-reviewer 审查修复），覆盖 media-server 子项目 从零到可用的全部工作。 【Task 0 - PoC Spike】 - media-server/poc/：Node + mediasoup + fastify-websocket + 前端 mediasoup-client - Playwright 双 tab 自动化验证 2 人会议：4 transports / 4 producers / 4 consumers / RSS 61MB - media-server/docs/poc-notes.md 归档 7 项关键坑 + 启动步骤 + Task 1/2/9 复用映射 - 锁定技术栈：mediasoup + fastify + mediasoup-client，不改用 livekit-server 【Task 1 - 骨架 + Fastify 5 升级】 - 依赖版本：mediasoup@3.19.0 + fastify@5.8.5 + fastify-plugin@5.1.0 + @fastify/sensible@6.0.4 + @fastify/websocket@11.2.0 + pino@9.3.2 + zod@3.23.8 - src 五件套：app.ts / config.ts / utils/logger.ts / mediasoup/worker.ts / middlewares/internal-auth.ts - /healthz + /readyz + /internal/info 三端点实测通过 - X-Internal-Token 鉴权用 timingSafeEqual 防侧信道 - mediasoup Worker died 指数退避自愈通过 kill -9 验证 - 多阶段 Dockerfile：非 root + curl HEALTHCHECK + 暴露 40000-40199 UDP/TCP - Fastify 4 → 5 升级：loggerInstance: logger 消灭两个 pino 实例 【Task 2 - 9 个内部 REST API + 审查修复】 接口全部挂 /internal/v1/* 前缀，覆盖 Router/Transport/Producer/Consumer 完整生命周期： - POST /routers, DELETE /routers/:id - POST /transports, POST /transports/:id/connect - POST /producers, DELETE /producers/:id - POST /consumers, POST /consumers/:id/resume, DELETE /consumers/:id 工程特性： - zod 手动 parse + 全局 errorHandler（不引入 fastify-type-provider-zod 避免 zod v4 依赖冲突） - AppError 统一错误码（NOT_FOUND/CONFLICT/CAN_NOT_CONSUME/ROUTER_LIMIT_EXCEEDED /MEDIASOUP_ERROR/VALIDATION_ERROR/UNAUTHORIZED/INTERNAL_ERROR） - 所有资源用 Map + observer.once('close') 自清理，Consumer 监听 producerclose 级联关闭 - Consumer 强制 paused:true 创建，/resume 独立接口 - Transport direction 强约束：recv 拒 produce、send 拒 consume code-reviewer 子代理审查"有条件通过"，同步修复： - M1 _clearXxxMap 新增 src/utils/test-guard.ts#assertTestOnly 守卫（生产误调用抛错） - M2 新增 src/schemas/rtp.ts 对 rtpParameters / rtpCapabilities 做 codecs 浅层校验 （mimeType/clockRate/payloadType 必填、codecs ≥1），消除 as unknown as 双跳断言 - m1 connectTransport 改乐观锁：先置位再 await，失败回退 - m2 改读 consumer.producerPaused（更符合 mediasoup 语义） - m3 producerclose 改为 once（风格一致） - m5 internal-auth 改为反向白名单 PRIVATE_PATH_PREFIXES = ['/internal/'] 验证： - typecheck / lint 0 错误 - vitest：65 passed / 8 spec 文件 - 覆盖率 stmts 82.87% / branches 75.83% / funcs 91.3% / lines 82.87% - 9 接口 happy path + 6 类错误路径 curl 手测全部按预期返回 【文档同步】 - CURRENT_STATUS.md +232 行：新增 Task 0/1/2 完整记录 + 代码审查修复章节 + 延后清单 - project-context.mdc：Task 0/1/2 状态同步 - phase2e-2-design.md +20 行：Fastify 5 升级相关决策记录 - phase2e-2-implementation.plan.md +117 行：Task 0/1/2 实际产出 + 修复记录 余下 Minor/Nits（m4/m6~m10/n1~n10）登记至 Task 16 收尾清单一次性清扫。 Made-with: Cursor
This commit is contained in:
bujinyuan
177
media-server/tests/schemas.spec.ts
Normal file
177
media-server/tests/schemas.spec.ts
Normal file
@@ -0,0 +1,177 @@
|
||||
import { describe, expect, it } from 'vitest';
|
||||
|
||||
import {
|
||||
idStringSchema,
|
||||
roomCodeSchema,
|
||||
userIdSchema,
|
||||
} from '../src/schemas/common.js';
|
||||
import { createConsumerBodySchema } from '../src/schemas/consumer.schema.js';
|
||||
import { createProducerBodySchema } from '../src/schemas/producer.schema.js';
|
||||
import { createRouterBodySchema } from '../src/schemas/router.schema.js';
|
||||
import {
|
||||
connectTransportBodySchema,
|
||||
createTransportBodySchema,
|
||||
} from '../src/schemas/transport.schema.js';
|
||||
|
||||
describe('common schemas', () => {
|
||||
it('accepts valid id strings', () => {
|
||||
expect(idStringSchema.parse('abc-123_X:Y')).toBe('abc-123_X:Y');
|
||||
});
|
||||
|
||||
it('rejects invalid characters in id', () => {
|
||||
expect(() => idStringSchema.parse('abc/def')).toThrow();
|
||||
expect(() => idStringSchema.parse('')).toThrow();
|
||||
expect(() => idStringSchema.parse('a'.repeat(200))).toThrow();
|
||||
});
|
||||
|
||||
it('accepts valid room codes', () => {
|
||||
expect(roomCodeSchema.parse('ROOM-001')).toBe('ROOM-001');
|
||||
});
|
||||
|
||||
it('rejects lowercase or invalid room codes', () => {
|
||||
expect(() => roomCodeSchema.parse('room-001')).toThrow();
|
||||
expect(() => roomCodeSchema.parse('AB')).toThrow();
|
||||
});
|
||||
|
||||
it('coerces numeric userIds into strings', () => {
|
||||
expect(userIdSchema.parse(42)).toBe('42');
|
||||
expect(userIdSchema.parse('alice')).toBe('alice');
|
||||
});
|
||||
|
||||
it('rejects non-positive numeric userIds', () => {
|
||||
expect(() => userIdSchema.parse(0)).toThrow();
|
||||
expect(() => userIdSchema.parse(-1)).toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('router schema', () => {
|
||||
it('parses valid body', () => {
|
||||
expect(createRouterBodySchema.parse({ roomCode: 'ROOM-1' })).toEqual({
|
||||
roomCode: 'ROOM-1',
|
||||
});
|
||||
});
|
||||
|
||||
it('rejects missing roomCode', () => {
|
||||
expect(() => createRouterBodySchema.parse({})).toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('transport schemas', () => {
|
||||
it('parses create body', () => {
|
||||
const parsed = createTransportBodySchema.parse({
|
||||
routerId: 'router-1',
|
||||
userId: 'user-1',
|
||||
direction: 'send',
|
||||
});
|
||||
expect(parsed.direction).toBe('send');
|
||||
});
|
||||
|
||||
it('rejects bad direction', () => {
|
||||
expect(() =>
|
||||
createTransportBodySchema.parse({
|
||||
routerId: 'router-1',
|
||||
userId: 'user-1',
|
||||
direction: 'bidirectional',
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
|
||||
it('parses connect body with fingerprints', () => {
|
||||
const parsed = connectTransportBodySchema.parse({
|
||||
dtlsParameters: {
|
||||
role: 'auto',
|
||||
fingerprints: [{ algorithm: 'sha-256', value: 'AA:BB' }],
|
||||
},
|
||||
});
|
||||
expect(parsed.dtlsParameters.fingerprints).toHaveLength(1);
|
||||
});
|
||||
|
||||
it('rejects connect body without fingerprints', () => {
|
||||
expect(() =>
|
||||
connectTransportBodySchema.parse({
|
||||
dtlsParameters: { role: 'auto', fingerprints: [] },
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('producer schema', () => {
|
||||
const validRtpParameters = {
|
||||
codecs: [
|
||||
{ mimeType: 'audio/opus', clockRate: 48000, payloadType: 100, channels: 2 },
|
||||
],
|
||||
};
|
||||
|
||||
it('parses valid body', () => {
|
||||
const parsed = createProducerBodySchema.parse({
|
||||
transportId: 'trans-1',
|
||||
kind: 'audio',
|
||||
rtpParameters: validRtpParameters,
|
||||
});
|
||||
expect(parsed.kind).toBe('audio');
|
||||
expect(parsed.rtpParameters.codecs[0]?.payloadType).toBe(100);
|
||||
});
|
||||
|
||||
it('rejects bad kind', () => {
|
||||
expect(() =>
|
||||
createProducerBodySchema.parse({
|
||||
transportId: 'trans-1',
|
||||
kind: 'data',
|
||||
rtpParameters: validRtpParameters,
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
|
||||
it('rejects rtpParameters without codecs', () => {
|
||||
expect(() =>
|
||||
createProducerBodySchema.parse({
|
||||
transportId: 'trans-1',
|
||||
kind: 'audio',
|
||||
rtpParameters: {},
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
|
||||
it('rejects rtpParameters with empty codecs', () => {
|
||||
expect(() =>
|
||||
createProducerBodySchema.parse({
|
||||
transportId: 'trans-1',
|
||||
kind: 'audio',
|
||||
rtpParameters: { codecs: [] },
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('consumer schema', () => {
|
||||
const validRtpCapabilities = {
|
||||
codecs: [{ mimeType: 'audio/opus', clockRate: 48000 }],
|
||||
};
|
||||
|
||||
it('parses valid body', () => {
|
||||
const parsed = createConsumerBodySchema.parse({
|
||||
routerId: 'r-1',
|
||||
transportId: 't-1',
|
||||
producerId: 'p-1',
|
||||
rtpCapabilities: validRtpCapabilities,
|
||||
});
|
||||
expect(parsed.routerId).toBe('r-1');
|
||||
});
|
||||
|
||||
it('rejects missing fields', () => {
|
||||
expect(() =>
|
||||
createConsumerBodySchema.parse({ routerId: 'r-1' }),
|
||||
).toThrow();
|
||||
});
|
||||
|
||||
it('rejects rtpCapabilities with empty codecs', () => {
|
||||
expect(() =>
|
||||
createConsumerBodySchema.parse({
|
||||
routerId: 'r-1',
|
||||
transportId: 't-1',
|
||||
producerId: 'p-1',
|
||||
rtpCapabilities: { codecs: [] },
|
||||
}),
|
||||
).toThrow();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user